hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16430) RegionServer Group's bug when move tables
Date Thu, 18 Aug 2016 14:23:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426539#comment-15426539
] 

Ted Yu commented on HBASE-16430:
--------------------------------

Is it possible to add a test ?

> RegionServer Group's bug when move tables
> -----------------------------------------
>
>                 Key: HBASE-16430
>                 URL: https://issues.apache.org/jira/browse/HBASE-16430
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 2.0.0
>            Reporter: Guangxu Cheng
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16430-v1.patch
>
>
> it is an obvious bug when moves table. Implementation of the moveTables as follows´╝Ü
> {code:title=RSGroupInfoManagerImpl.java|borderStyle=solid}
> @Override
>   public synchronized void moveTables(
>       Set<TableName> tableNames, String groupName) throws IOException {
>     if (groupName != null && !rsGroupMap.containsKey(groupName)) {
>       throw new DoNotRetryIOException("Group "+groupName+" does not exist or is a special
group");
>     }
>     Map<String,RSGroupInfo> newGroupMap = Maps.newHashMap(rsGroupMap);
>     for(TableName tableName: tableNames) {
>       if (tableMap.containsKey(tableName)) {
>         RSGroupInfo src = new RSGroupInfo(rsGroupMap.get(tableMap.get(tableName)));
>         src.removeTable(tableName);
>         newGroupMap.put(src.getName(), src);
>       }
>       if(groupName != null) {
>         RSGroupInfo dst = new RSGroupInfo(newGroupMap.get(groupName));
>         dst.addTable(tableName);
>         newGroupMap.put(dst.getName(), dst);
>       }
>     }
>     flushConfig(newGroupMap);
>   }
> {code}
> Should use newGroupMap instead of rsGroupMap:
> {code}
> RSGroupInfo src = new RSGroupInfo(rsGroupMap.get(tableMap.get(tableName)));
> {code}
> ==>
> {code}
> RSGroupInfo src = new RSGroupInfo(newGroupMap.get(tableMap.get(tableName)));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message