hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
Date Wed, 17 Aug 2016 00:17:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423641#comment-15423641

Dima Spivak commented on HBASE-16384:

Thanks for updating the script, [~appy]; way more readable IMHO. :) Some suggestions:

- Order imports alphabetically, but grouped as described in PEP 8.
- Can probably remove the brackets around the {{metavar}} for {{excluded_builds}} to be more
clear on how to pass arguments.
- In your new {{get_bad_tests}}, you removed the assignment of {{result}}. I'm also confused
about why the doc suggests you'll return a list, but then you actually return an empty dictionary
- Use {{enumerate}} in place of {{for i in range(len(job_urls))}} to stay Pythonic.

Other than that, basically looks good to me. It passing locally with and without your new
arguments in place?

> Update report-flakies.py script to allow specifying a list of build ids to be excluded
> --------------------------------------------------------------------------------------
>                 Key: HBASE-16384
>                 URL: https://issues.apache.org/jira/browse/HBASE-16384
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-16384.master.001.patch, HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, HBASE-16384.master.006.patch
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This makes  [flaky
go crazy.
> This patch adds that feature to specify build ids to exclude in report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option in --urls
param and rerun the job to fix the flaky list.

This message was sent by Atlassian JIRA

View raw message