hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16377) ServerName check is ineffective in region_mover.rb
Date Tue, 09 Aug 2016 20:58:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414228#comment-15414228
] 

Hadoop QA commented on HBASE-16377:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s {color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s {color} | {color:blue}
The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 1s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 4s {color} | {color:red}
The patch generated 4 new + 321 unchanged - 3 fixed = 325 total (was 324) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m 2s {color} |
{color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 45s {color}
| {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 1m 33s {color} | {color:red}
root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 46s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 8s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-09 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12822874/16377.branch-1.v1.txt
|
| JIRA Issue | HBASE-16377 |
| Optional Tests |  asflicense  rubocop  ruby_lint  |
| uname | Linux 1a565008b6e7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1 / 441bc05 |
| rubocop | v0.42.0 |
| rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/3034/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.0 |
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/3034/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3034/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> ServerName check is ineffective in region_mover.rb
> --------------------------------------------------
>
>                 Key: HBASE-16377
>                 URL: https://issues.apache.org/jira/browse/HBASE-16377
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.2
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16377.branch-1.v1.txt
>
>
> The following was observed during test of region_mover.rb :
> {code}
> 2016-08-08 11:17:05,341|beaver.machine|INFO|352|139926954637120|MainThread|2016-08-08
11:17:05,340 INFO  [RubyThread-9: hbase-client/bin/thread-pool.rb:28] region_mover: Moving
region  hbase:meta,,1.1588230740 (1 of 14) from xyz.openstacklocal,16020,1470654716593, to
server=xyz.openstacklocal,16020,1470654716593
> {code}
> There is check that target server should not be the same as current server:
> {code}
>     if currentServer and currentServer == servername
>       $LOG.info("Region " + r.getRegionNameAsString() + " (" + counter.to_s +
>         " of " + regions.length.to_s + ") already on target server=" + servername)
>       counter = counter + 1
>       next
>     end
> {code}
> However, the check is not effective.
> See comparison between object1 and object3:
> http://www.skorks.com/2009/09/ruby-equality-and-object-comparison/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message