hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16353) Deprecate / Remove Get.isClosestRowBefore()
Date Thu, 04 Aug 2016 17:53:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408203#comment-15408203
] 

Yi Liang commented on HBASE-16353:
----------------------------------

I have done some research in the code, found that 
1. in 2.0 branch
(1) All the getClosestRow related methods have been removed, except the one in HBaseTestingUtility.
And that one in HBaseTestUtility is implemented using reversed scanner, so no need to remove
this one. 
(2) I did not found any related filed in PB, it seems the below filed has been removed in
2.0   
 optional bool closest_row_before = 11 [default = false]; (which found in 1.4 client.proto)

So, for 2.0 we just need to remove Get.setClosestRowBefore() / isClosestRowBefore, and in
1.4 we need more modify. 

I will first attach the patch for 2.0 now, and if patch for 1.4 is needed, I will attach it
later. 




> Deprecate / Remove Get.isClosestRowBefore() 
> --------------------------------------------
>
>                 Key: HBASE-16353
>                 URL: https://issues.apache.org/jira/browse/HBASE-16353
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>              Labels: beginner
>             Fix For: 2.0.0, 1.4.0
>
>
> We no longer have "get closest row" functionality in 1.0+. We forgot to remove Get.setClosestRowBefore()
/  isClosestRowBefore and deprecate the field in PB {{closest_row_before}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message