hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16327) Unify BufferChain and MultiByteBuff
Date Wed, 03 Aug 2016 04:54:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405310#comment-15405310
] 

ramkrishna.s.vasudevan commented on HBASE-16327:
------------------------------------------------

bq.MBB creation will have some extra overhead. Like the creation of 'itemBeginPos' array,
calculation of offsets etc. Those are not really needed for a BufferChain
I agree. But they can be by passed?  Just add write() API that writes to GatheringByteChannel.
Actually functionally both are same MBB and BufferChain - it wraps a list of BBs. 


> Unify BufferChain and MultiByteBuff
> -----------------------------------
>
>                 Key: HBASE-16327
>                 URL: https://issues.apache.org/jira/browse/HBASE-16327
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>
> Bufferchain is nothing but a collection of Bytebuffers. We already have MultiBytebuff.
May be we can unify both and add the Bufferchain#write() to ByteBuff abstract class. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message