hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16321) Ensure findbugs jsr305 jar isn't present
Date Mon, 08 Aug 2016 00:05:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411123#comment-15411123
] 

Andrew Purtell edited comment on HBASE-16321 at 8/8/16 12:04 AM:
-----------------------------------------------------------------

I need to partially revert and amend this change. 

With 0.98, where we require Java 6 to build, this change causes the build to inexplicably
fail in compilation of hbase-common. Although the failure is silent, it is because the class
file versions of the replacement jsr305 classes are too recent.

What I am going to do to fix this in 0.98 is keep the enforcement ban and exclusions in place,
but remove all instances of findbugs annotations. And not specify the replacement jsr305 dependency
either.


was (Author: apurtell):
I need to partially revert and amend this change. 

With 0.98, where we require Java 6 to build, this change causes the build to inexplicably
fail in compilation of hbase-common. Although the failure is silent, it is because the class
file versions of the replacement jsr305 classes are too recent.

What I am going to do to fix this in 0.98 is keep the enforcement ban and exclusions in place,
but remove all instances of findbugs annotations.

> Ensure findbugs jsr305 jar isn't present
> ----------------------------------------
>
>                 Key: HBASE-16321
>                 URL: https://issues.apache.org/jira/browse/HBASE-16321
>             Project: HBase
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 0.98.21, 1.2.3
>
>         Attachments: 16321-amend.txt, HBASE-16321.1.patch, HBASE-16321.2.patch
>
>
> we should be using
> {code}
> <dependencies>
>     <dependency>
>       <groupId>com.github.stephenc.findbugs</groupId>
>       <artifactId>findbugs-annotations</artifactId>
>       <version>${findbugs-annotations}</version>
>       <scope>compile</scope>
>     </dependency>
> {code}
>  to ensure we don't have a prohibited dependency, but it looks like we're still bringing
in
> {code}
> <dependency>
>          <groupId>com.google.code.findbugs</groupId>
>          <artifactId>jsr305</artifactId>
>          <version>${jsr305.version}</version>
>       </dependency>
> {code}
> remove the findbugs version (even though the maven central pom claims the license is
ALv2, that doesn't line up with the referenced project sites).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message