hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16321) Ensure findbugs jsr305 jar isn't present
Date Thu, 04 Aug 2016 05:11:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407170#comment-15407170

Sean Busbey commented on HBASE-16321:

bq. except in the hbase-spark module since apparently spark-core can't function without it.
So, umm, what then? There's a ticket to be filed vs. spark that blocks this one? Without that,
we can't not include this jar in our dist, right?

We could file a ticket against spark, but I have it worked around for now. The dependency
is in the hbase-spark module set to provided and optional, so even though we have it when
we compile against spark-core, we don't pass it on to either our packaging or downstream users
of us. If they depend on us and spark-core, they'll get it from spark core (or decide they
don't want it from spark core like we are). We don't package spark-core in our dist at all,
AFAIK, so we needn't package any of its runtime dependencies.

> Ensure findbugs jsr305 jar isn't present
> ----------------------------------------
>                 Key: HBASE-16321
>                 URL: https://issues.apache.org/jira/browse/HBASE-16321
>             Project: HBase
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 1.2.3
>         Attachments: HBASE-16321.1.patch, HBASE-16321.2.patch
> we should be using
> {code}
> <dependencies>
>     <dependency>
>       <groupId>com.github.stephenc.findbugs</groupId>
>       <artifactId>findbugs-annotations</artifactId>
>       <version>${findbugs-annotations}</version>
>       <scope>compile</scope>
>     </dependency>
> {code}
>  to ensure we don't have a prohibited dependency, but it looks like we're still bringing
> {code}
> <dependency>
>          <groupId>com.google.code.findbugs</groupId>
>          <artifactId>jsr305</artifactId>
>          <version>${jsr305.version}</version>
>       </dependency>
> {code}
> remove the findbugs version (even though the maven central pom claims the license is
ALv2, that doesn't line up with the referenced project sites).

This message was sent by Atlassian JIRA

View raw message