hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-16311) Audit log for delete snapshot operation is missing in case of snapshot owner deleting the same
Date Mon, 01 Aug 2016 20:28:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matteo Bertozzi updated HBASE-16311:
------------------------------------
    Description: 
1. Audit log seems to be left as a TODO task in AccessController.java:
{code}
  @Override
  public void preDeleteSnapshot(final ObserverContext<MasterCoprocessorEnvironment>
ctx,
      final SnapshotDescription snapshot) throws IOException {
    if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
      // Snapshot owner is allowed to delete the snapshot
      // TODO: We are not logging this for audit
    } else {
      requirePermission("deleteSnapshot", Action.ADMIN);
    }
  }
{code}
2. Also, snapshot name is not getting logged in the audit logs.

  was:
1. Audit log seems to be left as a TODO task in AccessController.java:
...................
@Override
  public void preDeleteSnapshot(final ObserverContext<MasterCoprocessorEnvironment>
ctx,
      final SnapshotDescription snapshot) throws IOException {
    if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
      // Snapshot owner is allowed to delete the snapshot
      // TODO: We are not logging this for audit
    } else {
      requirePermission("deleteSnapshot", Action.ADMIN);
    }
  }
...................
2. Also, snapshot name is not getting logged in the audit logs.


> Audit log for delete snapshot operation is missing in case of snapshot owner deleting
the same
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16311
>                 URL: https://issues.apache.org/jira/browse/HBASE-16311
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Abhishek Kumar
>            Assignee: Abhishek Kumar
>            Priority: Minor
>
> 1. Audit log seems to be left as a TODO task in AccessController.java:
> {code}
>   @Override
>   public void preDeleteSnapshot(final ObserverContext<MasterCoprocessorEnvironment>
ctx,
>       final SnapshotDescription snapshot) throws IOException {
>     if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
>       // Snapshot owner is allowed to delete the snapshot
>       // TODO: We are not logging this for audit
>     } else {
>       requirePermission("deleteSnapshot", Action.ADMIN);
>     }
>   }
> {code}
> 2. Also, snapshot name is not getting logged in the audit logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message