hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
Date Sun, 07 Aug 2016 19:00:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411034#comment-15411034
] 

Andrew Purtell commented on HBASE-16303:
----------------------------------------

[~ramkrishna.s.vasudevan@gmail.com], please check *compilation* before committing. This is
the most basic of checks a committer can do. It shouldn't be necessary to ask!

> FilterList with MUST_PASS_ONE optimization
> ------------------------------------------
>
>                 Key: HBASE-16303
>                 URL: https://issues.apache.org/jira/browse/HBASE-16303
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16303.patch, HBASE-16303.patch, HBASE-16303_1.patch, HBASE-16303_1.patch
>
>
> This JIRA was created to add @Test tag for all the filter related tests. After doing
that one such test failed in TestFilterList#testFilterListTwoFiltersMustPassOne.
> The test assumes that when a PrefixFilter is added to a filterlist once the given prefix
is passed we should SKIP all other rows. But the impl in FilterList for MUST_PASS_ONE filter
is such that once the filter in the list sees that filterAllRemaining is true we don't use
that to decide if to to SEE_NEXT_USING_HINT or not. This patch tries to handle that case where
if for a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be done. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message