hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
Date Fri, 05 Aug 2016 17:41:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409774#comment-15409774
] 

Hudson commented on HBASE-16303:
--------------------------------

FAILURE: Integrated in HBase-1.4 #334 (See [https://builds.apache.org/job/HBase-1.4/334/])
HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) (ramkrishna: rev 6278ece8b6cbe3fae0e8618dd25ab03533113095)
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
HBASE-16303 Addendum as the wrong patch was committed (ramkrishna: rev 7a62076ae45ad91a20df66528d8b5cd09a0e4251)
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java


> FilterList with MUST_PASS_ONE optimization
> ------------------------------------------
>
>                 Key: HBASE-16303
>                 URL: https://issues.apache.org/jira/browse/HBASE-16303
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16303.patch, HBASE-16303.patch, HBASE-16303_1.patch, HBASE-16303_1.patch
>
>
> This JIRA was created to add @Test tag for all the filter related tests. After doing
that one such test failed in TestFilterList#testFilterListTwoFiltersMustPassOne.
> The test assumes that when a PrefixFilter is added to a filterlist once the given prefix
is passed we should SKIP all other rows. But the impl in FilterList for MUST_PASS_ONE filter
is such that once the filter in the list sees that filterAllRemaining is true we don't use
that to decide if to to SEE_NEXT_USING_HINT or not. This patch tries to handle that case where
if for a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be done. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message