hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
Date Fri, 05 Aug 2016 05:37:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ramkrishna.s.vasudevan updated HBASE-16303:
-------------------------------------------
      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Pushed to master, branch-1 and 1.3
For other branches adding the @Test to test case will fail the test cases. So do we need the
fix in other branches also? 
[~ndimiduk], [~busbey],[~apurtell]
The fix as such may not cause a wrong result when PrefixFiter is used with a filterlist but
may cause unnecessary results to be retrieved. I have not verified this with a cluster but
can see from what the test expects and what the code does. 

> FilterList with MUST_PASS_ONE optimization
> ------------------------------------------
>
>                 Key: HBASE-16303
>                 URL: https://issues.apache.org/jira/browse/HBASE-16303
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16303.patch, HBASE-16303.patch, HBASE-16303_1.patch, HBASE-16303_1.patch
>
>
> This JIRA was created to add @Test tag for all the filter related tests. After doing
that one such test failed in TestFilterList#testFilterListTwoFiltersMustPassOne.
> The test assumes that when a PrefixFilter is added to a filterlist once the given prefix
is passed we should SKIP all other rows. But the impl in FilterList for MUST_PASS_ONE filter
is such that once the filter in the list sees that filterAllRemaining is true we don't use
that to decide if to to SEE_NEXT_USING_HINT or not. This patch tries to handle that case where
if for a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be done. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message