hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16272) Overflow in ServerName's compareTo method
Date Mon, 01 Aug 2016 22:43:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402967#comment-15402967
] 

Andrew Purtell edited comment on HBASE-16272 at 8/1/16 10:43 PM:
-----------------------------------------------------------------

The 0.98 commit needs an addendum:
{noformat}
[ERROR] hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java:[293,15] cannot
find symbol
[ERROR] symbol  : method compare(long,long)
[ERROR] location: class java.lang.Long
{noformat}
and 9 others due to lack of Long.compare() in JDK/JRE 6

Working on it. Will commit addendum shortly.


was (Author: apurtell):
The 0.98 commit needs an addendum:
{noformat}
[ERROR] hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java:[293,15] cannot
find symbol
[ERROR] symbol  : method compare(long,long)
[ERROR] location: class java.lang.Long
{noformat}
and 9 others due to lack of Long.compare() in JDK/JRE 6

> Overflow in ServerName's compareTo method
> -----------------------------------------
>
>                 Key: HBASE-16272
>                 URL: https://issues.apache.org/jira/browse/HBASE-16272
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 0.98.21, 1.2.3
>
>         Attachments: HBASE-16272-v001.patch
>
>
> Looking at the ServerName's compareTo(), 
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java#L303
> It converts the return int value by converting long to int like (int)(longValue), which
could be incorrect when it overflows, need to replace it with Long.compareTo(a,b).
> [~mbertozzi] found some others as well, such as
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java#L990



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message