hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudeep Sunthankar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15893) Get object
Date Wed, 10 Aug 2016 03:14:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sudeep Sunthankar updated HBASE-15893:
--------------------------------------
    Attachment: HBASE-15893.HBASE-14850.v4.patch

This patches addresses the below points as per the last feedback

1) We already have a Consistency enum don't duplicate that
    --- Using Consistency enum defined in if/Client.proto
2) Naming of GET_FAMILY_MAP
    --- Changed to FAMILY_MAP
3) prefer constexpr over const static in a class. Better yet just don't expose that constant
at all.
    --- Moved the constant to a local variable in CheckRow()
4) Added comments for methods
5) Tests hooked up to client

> Get object
> ----------
>
>                 Key: HBASE-15893
>                 URL: https://issues.apache.org/jira/browse/HBASE-15893
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-15893.HBASE-14850.v1.patch, HBASE-15893.HBASE-14850.v2.patch,
HBASE-15893.HBASE-14850.v3.patch, HBASE-15893.HBASE-14850.v4.patch
>
>
> Patch for creating Get objects.  Get objects can be passed to the Table implementation
to fetch results for a given row. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message