Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6226C200B5F for ; Fri, 29 Jul 2016 19:09:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 60B2F160A6E; Fri, 29 Jul 2016 17:09:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A9E66160A79 for ; Fri, 29 Jul 2016 19:09:21 +0200 (CEST) Received: (qmail 97212 invoked by uid 500); 29 Jul 2016 17:09:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 97076 invoked by uid 99); 29 Jul 2016 17:09:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2016 17:09:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8B68E2C0D60 for ; Fri, 29 Jul 2016 17:09:20 +0000 (UTC) Date: Fri, 29 Jul 2016 17:09:20 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16300) LruBlockCache.CACHE_FIXED_OVERHEAD should calculate LruBlockCache size correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 29 Jul 2016 17:09:22 -0000 [ https://issues.apache.org/jira/browse/HBASE-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399695#comment-15399695 ] Hudson commented on HBASE-16300: -------------------------------- FAILURE: Integrated in HBase-0.98-matrix #378 (See [https://builds.apache.org/job/HBase-0.98-matrix/378/]) HBASE-16300 LruBlockCache.CACHE_FIXED_OVERHEAD should calculate (liyu: rev 27c583467e53cb52667eff45afabb1ffb8547be5) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java > LruBlockCache.CACHE_FIXED_OVERHEAD should calculate LruBlockCache size correctly > -------------------------------------------------------------------------------- > > Key: HBASE-16300 > URL: https://issues.apache.org/jira/browse/HBASE-16300 > Project: HBase > Issue Type: Bug > Reporter: Yu Sun > Assignee: Yu Sun > Fix For: 2.0.0, 1.3.0, 0.98.21, 1.2.3 > > Attachments: HBASE-16300-v1.patch > > > in current master {{LruBlockCache}}, CACHE_FIXED_OVERHEAD is calculated as this: > {code} > public final static long CACHE_FIXED_OVERHEAD = ClassSize.align( > (3 * Bytes.SIZEOF_LONG) + (10 * ClassSize.REFERENCE) + > (5 * Bytes.SIZEOF_FLOAT) + (2 * Bytes.SIZEOF_BOOLEAN) > + ClassSize.OBJECT); > {code} > after some investigation. I think there are some wrong here, {{class LruBlockCache}}, except static varible(which is belongs to class), there are 4 long varibles(maxBlockSize,maxSize,blockSize and overhead), 9 reference varibles and 2 boolean varibles, so the above code will not calculate LruBlockCache instance size correctly. > current related ut not failed mostly due to the result is 8 bytes aligned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)