Return-Path: <issues-return-251494-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 5BBA3200B45
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 15 Jul 2016 12:51:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 5A61C160A6C; Fri, 15 Jul 2016 10:51:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A1F53160A61
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 15 Jul 2016 12:51:21 +0200 (CEST)
Received: (qmail 69005 invoked by uid 500); 15 Jul 2016 10:51:20 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 68994 invoked by uid 99); 15 Jul 2016 10:51:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 10:51:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8C2652C0034
	for <issues@hbase.apache.org>; Fri, 15 Jul 2016 10:51:20 +0000 (UTC)
Date: Fri, 15 Jul 2016 10:51:20 +0000 (UTC)
From: "ChiaPing Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12989692.1468564900000.40502.1468579880571@Atlassian.JIRA>
In-Reply-To: <JIRA.12989692.1468564900000@Atlassian.JIRA>
References: <JIRA.12989692.1468564900000@Atlassian.JIRA> <JIRA.12989692.1468564900304@arcas>
Subject: [jira] [Commented] (HBASE-16235)
 TestSnapshotFromMaster#testSnapshotHFileArchiving will fail if there are
 too many hfiles
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 15 Jul 2016 10:51:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16235?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D153=
79222#comment-15379222 ]=20

ChiaPing Tsai commented on HBASE-16235:
---------------------------------------

You are right.

thanks

> TestSnapshotFromMaster#testSnapshotHFileArchiving will fail if there are =
too many hfiles
> -------------------------------------------------------------------------=
---------------
>
>                 Key: HBASE-16235
>                 URL: https://issues.apache.org/jira/browse/HBASE-16235
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>         Attachments: HBASE-16235-v1.patch
>
>
> TestSnapshotFromMaster#testSnapshotHFileArchiving assumes that all hfiles=
 will be compacted and be moved to =E2=80=9Carchive folder=E2=80=9D after c=
leaning. But not all hfiles will be compacted if there are large number of =
hfiles.
> The above may be happened if changing the default config like smaller wri=
te buffer(hbase.client.write.buffer) or ExponentialClientBackoffPolicy.
> {code:title=3DTestSnapshotFromMaster.java|borderStyle=3Dsolid}
> // it should also check the hfiles in the normal path (/hbase/data/defaul=
t/...)
> public void testSnapshotHFileArchiving() throws Exception {
>   //...
>   // get the archived files for the table
>     Collection<String> files =3D getArchivedHFiles(archiveDir, rootDir, f=
s, TABLE_NAME);
>     // and make sure that there is a proper subset
>     for (String fileName : snapshotHFiles) {
>       assertTrue("Archived hfiles " + files + " is missing snapshot file:=
" + fileName,
>         files.contains(fileName));
>     }
>   //...
> }  =20
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)