Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4D8A8200B58 for ; Tue, 12 Jul 2016 20:17:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4C3BC160A56; Tue, 12 Jul 2016 18:17:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4C0EE160A8B for ; Tue, 12 Jul 2016 20:17:22 +0200 (CEST) Received: (qmail 82987 invoked by uid 500); 12 Jul 2016 18:17:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 82590 invoked by uid 99); 12 Jul 2016 18:17:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2016 18:17:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E1A3A2C02AA for ; Tue, 12 Jul 2016 18:17:20 +0000 (UTC) Date: Tue, 12 Jul 2016 18:17:20 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16207) can't restore snapshot without "Admin" permission MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 12 Jul 2016 18:17:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373376#comment-15373376 ] Hudson commented on HBASE-16207: -------------------------------- FAILURE: Integrated in HBase-1.3 #780 (See [https://builds.apache.org/job/HBase-1.3/780/]) HBASE-16207 can't restore snapshot without "Admin" permission (matteo.bertozzi: rev 51eee9a22f1398168bedcb19ab6e2b6a5eb7c4bf) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > can't restore snapshot without "Admin" permission > ------------------------------------------------- > > Key: HBASE-16207 > URL: https://issues.apache.org/jira/browse/HBASE-16207 > Project: HBase > Issue Type: Bug > Components: master, snapshots > Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.1.5 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Fix For: 2.0.0, 1.2.2, 1.1.6, 1.3.1, 0.98.21 > > Attachments: HBASE-16207-v0.patch, HBASE-16207-v0_branch-1.patch > > > MasterRpcServices.restoreSnapshot() tries to verify if the NS exists before starting the restore, but instead of calling ensureNamespaceExists() it calls master.getNamespace() which requires ADMIN permission to get the NS descriptor. > {code} > public RestoreSnapshotResponse restoreSnapshot(RpcController controller, > ... > // Ensure namespace exists. Will throw exception if non-known NS. > master.getNamespace(dstTable.getNamespaceAsString()); > {code} > unfortunately i'm not aware of any unit-test that cover this kind of situations. we cover single ACLs from the TestAccessController but we don't exercise rpc calls and verify if there is more than one check on the ACLs like in this case -- This message was sent by Atlassian JIRA (v6.3.4#6332)