Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 22 Jul 2016 06:45:21 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12988202.1468219623000.104340.1469169921148@Atlassian.JIRA>
In-Reply-To: <JIRA.12988202.1468219623000@Atlassian.JIRA>
References: <JIRA.12988202.1468219623000@Atlassian.JIRA> <JIRA.12988202.1468219623092@arcas>
Subject: [jira] [Commented] (HBASE-16205) When Cells are not copied to
 MSLAB, deep clone it while adding to Memstore
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 22 Jul 2016 06:45:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389025#comment-15389025 ] 

ramkrishna.s.vasudevan commented on HBASE-16205:
------------------------------------------------

Just a question. So now deepCloneIfNEeded() is inside add() then would be much cleaner. But upsert() is calling internalAdd() only. What is the reason that the upsert cell need not be cloned to MSLAB if it is available? 
Rest looks good to me. 

> When Cells are not copied to MSLAB, deep clone it while adding to Memstore
> --------------------------------------------------------------------------
>
>                 Key: HBASE-16205
>                 URL: https://issues.apache.org/jira/browse/HBASE-16205
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16205.patch, HBASE-16205_V2.patch, HBASE-16205_V3.patch, HBASE-16205_V3.patch
>
>
> This is imp after HBASE-15180 optimization. After that we the cells flowing in write path will be backed by the same byte[] where the RPC read the request into. By default we have MSLAB On and so we have a copy operation while adding Cells to memstore.  This copy might not be there if
> 1. MSLAB is turned OFF
> 2. Cell size is more than a configurable max size. This defaults to 256 KB
> 3. If the operation is Append/Increment. 
> In such cases, we should just clone the Cell into a new byte[] and then add to memstore.  Or else we keep referring to the bigger byte[] chunk for longer time.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)