Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 79DE5200B46 for ; Fri, 1 Jul 2016 21:09:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 78BD2160A6D; Fri, 1 Jul 2016 19:09:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BE846160A6C for ; Fri, 1 Jul 2016 21:09:12 +0200 (CEST) Received: (qmail 92704 invoked by uid 500); 1 Jul 2016 19:09:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92626 invoked by uid 99); 1 Jul 2016 19:09:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 19:09:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 558462C02A9 for ; Fri, 1 Jul 2016 19:09:11 +0000 (UTC) Date: Fri, 1 Jul 2016 19:09:11 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16157) The incorrect block cache count and size are caused by removing duplicate block key in the LruBlockCache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Jul 2016 19:09:13 -0000 [ https://issues.apache.org/jira/browse/HBASE-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359488#comment-15359488 ] Hadoop QA commented on HBASE-16157: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} | {color:red} HBASE-16157 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12815805/HBASE-16157-v3.patch | | JIRA Issue | HBASE-16157 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2484/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > The incorrect block cache count and size are caused by removing duplicate block key in the LruBlockCache > -------------------------------------------------------------------------------------------------------- > > Key: HBASE-16157 > URL: https://issues.apache.org/jira/browse/HBASE-16157 > Project: HBase > Issue Type: Bug > Reporter: ChiaPing Tsai > Priority: Trivial > Attachments: HBASE-16157-v1.patch, HBASE-16157-v2.patch, HBASE-16157-v3.patch > > > {code:title=LruBlockCache.java|borderStyle=solid} > // Check return value from the Map#remove before updating the metrics > protected long evictBlock(LruCachedBlock block, boolean evictedByEvictionProcess) { > map.remove(block.getCacheKey()); > updateSizeMetrics(block, true); > ... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)