Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 8 Jul 2016 00:35:11 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12984186.1467075275000.53422.1467938111192@Atlassian.JIRA>
In-Reply-To: <JIRA.12984186.1467075275000@Atlassian.JIRA>
References: <JIRA.12984186.1467075275000@Atlassian.JIRA> <JIRA.12984186.1467075275074@arcas>
Subject: [jira] [Commented] (HBASE-16132) Scan does not return all the
 result when regionserver is busy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Jul 2016 00:35:13 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367020#comment-15367020 ] 

Hudson commented on HBASE-16132:
--------------------------------

SUCCESS: Integrated in HBase-1.1-JDK7 #1741 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1741/])
HBASE-16132 Scan does not return all the result when regionserver is (liyu: rev dcc1243f61332b696e1df193d553249b469c0e63)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java


> Scan does not return all the result when regionserver is busy
> -------------------------------------------------------------
>
>                 Key: HBASE-16132
>                 URL: https://issues.apache.org/jira/browse/HBASE-16132
>             Project: HBase
>          Issue Type: Bug
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0, 1.3.0, 1.2.2, 1.1.6
>
>         Attachments: HBASE-16132.patch, HBASE-16132_v2.patch, HBASE-16132_v3.patch, HBASE-16132_v3.patch, TestScanMissingData.java
>
>
> We have find some corner case, when regionserver is busy and last a long time. Some scanner may return null even if they do not scan all data.
> We find in ScannerCallableWithReplicas there is a case do not handler correct, when cs.poll timeout and do not return any result , it is will return a null result, so scan get null result, and end the scan. 
>  {code}
>     try {
>       Future<Pair<Result[], ScannerCallable>> f = cs.poll(timeout, TimeUnit.MILLISECONDS);
>       if (f != null) {
>         Pair<Result[], ScannerCallable> r = f.get(timeout, TimeUnit.MILLISECONDS);
>         if (r != null && r.getSecond() != null) {
>           updateCurrentlyServingReplica(r.getSecond(), r.getFirst(), done, pool);
>         }
>         return r == null ? null : r.getFirst(); // great we got an answer
>       }
>     } catch (ExecutionException e) {
>       RpcRetryingCallerWithReadReplicas.throwEnrichedException(e, retries);
>     } catch (CancellationException e) {
>       throw new InterruptedIOException(e.getMessage());
>     } catch (InterruptedException e) {
>       throw new InterruptedIOException(e.getMessage());
>     } catch (TimeoutException e) {
>       throw new InterruptedIOException(e.getMessage());
>     } finally {
>       // We get there because we were interrupted or because one or more of the
>       // calls succeeded or failed. In all case, we stop all our tasks.
>       cs.cancelAll();
>     }
>     return null; // unreachable
>  {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)