Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 997B8200B62 for ; Fri, 29 Jul 2016 00:41:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9800E160AA9; Thu, 28 Jul 2016 22:41:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF3F6160A85 for ; Fri, 29 Jul 2016 00:41:21 +0200 (CEST) Received: (qmail 89848 invoked by uid 500); 28 Jul 2016 22:41:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 89819 invoked by uid 99); 28 Jul 2016 22:41:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2016 22:41:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 823792C0D5E for ; Thu, 28 Jul 2016 22:41:20 +0000 (UTC) Date: Thu, 28 Jul 2016 22:41:20 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16096) Replication keeps accumulating znodes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 28 Jul 2016 22:41:22 -0000 [ https://issues.apache.org/jira/browse/HBASE-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398352#comment-15398352 ] Hudson commented on HBASE-16096: -------------------------------- SUCCESS: Integrated in HBase-1.3 #796 (See [https://builds.apache.org/job/HBase-1.3/796/]) HBASE-16096 Backport. Cleanly remove replication peers from ZooKeeper. (eclark: rev 909f06147741f232d76bc411ffdd09f2627ca014) * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > Replication keeps accumulating znodes > ------------------------------------- > > Key: HBASE-16096 > URL: https://issues.apache.org/jira/browse/HBASE-16096 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.2.0, 1.3.0 > Reporter: Ashu Pachauri > Assignee: Joseph > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16096-branch-1.patch, HBASE-16096.patch > > > If there is an error while creating the replication source on adding the peer, the source if not added to the in memory list of sources but the replication peer is. > However, in such a scenario, when you remove the peer, it is deleted from zookeeper successfully but for removing the in memory list of peers, we wait for the corresponding sources to get deleted (which as we said don't exist because of error creating the source). > The problem here is the ordering of operations for adding/removing source and peer. > Modifying the code to always remove queues from the underlying storage, even if there exists no sources also requires a small refactoring of TableBasedReplicationQueuesImpl to not abort on removeQueues() of an empty queue -- This message was sent by Atlassian JIRA (v6.3.4#6332)