Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A7A4B200B45 for ; Fri, 1 Jul 2016 06:19:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A61C9160A63; Fri, 1 Jul 2016 04:19:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2115B160A52 for ; Fri, 1 Jul 2016 06:19:11 +0200 (CEST) Received: (qmail 81411 invoked by uid 500); 1 Jul 2016 04:19:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81385 invoked by uid 99); 1 Jul 2016 04:19:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 04:19:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0A4722C02A1 for ; Fri, 1 Jul 2016 04:19:11 +0000 (UTC) Date: Fri, 1 Jul 2016 04:19:11 +0000 (UTC) From: "Heng Chen (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15844) We should respect hfile.block.index.cacheonwrite when write intermediate index Block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Jul 2016 04:19:12 -0000 [ https://issues.apache.org/jira/browse/HBASE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-15844: ------------------------------ Attachment: HBASE-15844_v1.patch > We should respect hfile.block.index.cacheonwrite when write intermediate index Block > ------------------------------------------------------------------------------------ > > Key: HBASE-15844 > URL: https://issues.apache.org/jira/browse/HBASE-15844 > Project: HBase > Issue Type: Bug > Reporter: Heng Chen > Fix For: 2.0.0 > > Attachments: HBASE-15844.patch, HBASE-15844_v1.patch > > > {code: title=BlockIndexWriter#writeIntermediateBlock} > if (cacheConf != null) { > HFileBlock blockForCaching = blockWriter.getBlockForCaching(cacheConf); > cacheConf.getBlockCache().cacheBlock(new BlockCacheKey(nameForCaching, > beginOffset, true, blockForCaching.getBlockType()), blockForCaching); > } > {code} > The if condition should be ? > {code} > if (cacheConf != null && cacheConf.shouldCacheIndexesOnWrite()) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)