Return-Path: <issues-return-250501-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BE428200B4C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  8 Jul 2016 01:47:12 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id BCE73160A68; Thu,  7 Jul 2016 23:47:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0F2D9160A72
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  8 Jul 2016 01:47:11 +0200 (CEST)
Received: (qmail 22271 invoked by uid 500); 7 Jul 2016 23:47:11 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 22250 invoked by uid 99); 7 Jul 2016 23:47:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2016 23:47:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id F15042C02A5
	for <issues@hbase.apache.org>; Thu,  7 Jul 2016 23:47:10 +0000 (UTC)
Date: Thu, 7 Jul 2016 23:47:10 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12960486.1461187165000.53126.1467935230986@Atlassian.JIRA>
In-Reply-To: <JIRA.12960486.1461187165000@Atlassian.JIRA>
References: <JIRA.12960486.1461187165000@Atlassian.JIRA> <JIRA.12960486.1461187165595@arcas>
Subject: [jira] [Commented] (HBASE-15682) HBase Backup Phase 3: Possible
 data loss during incremental WAL files copy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 07 Jul 2016 23:47:12 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366974#comment-15366974 ] 

Ted Yu commented on HBASE-15682:
--------------------------------

{code}
+            StringUtils.join(incrBackupFileList, ",") +" to "
{code}
  public static String join(CharSequence separator, Iterable<?> strings) {

Separator goes first.
{code}
+        List<String> converted = convertFilesFromWALtoOldWAL(missingFiles);
{code}
The above is called twice: once inside updateIncrBackupFileList() and once after calling updateIncrBackupFileList().
See if the return value can be reused.
{code}
+    for(String path: missingFiles){
+      if(path.indexOf(Path.SEPARATOR + HConstants.HREGION_LOGDIR_NAME) < 0) {
{code}
nit: insert space between for and (.
{code}
+    while(!success){
{code}
Should there be limit on the number of retries ?

> HBase Backup Phase 3: Possible data loss during incremental WAL files copy
> --------------------------------------------------------------------------
>
>                 Key: HBASE-15682
>                 URL: https://issues.apache.org/jira/browse/HBASE-15682
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15682-v2.patch
>
>
> We collect list of files in WAL and oldWALs directory and launch DistCp job. Some files can be moved from WALs to oldWALs  directory by RS during job's run, what can result in potential data loss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)