Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Jul 2016 03:41:20 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12958287.1460501551000.165005.1469763680824@Atlassian.JIRA>
In-Reply-To: <JIRA.12958287.1460501551000@Atlassian.JIRA>
References: <JIRA.12958287.1460501551000@Atlassian.JIRA> <JIRA.12958287.1460501551895@arcas>
Subject: [jira] [Commented] (HBASE-15638) Shade protobuf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Jul 2016 03:41:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398663#comment-15398663 ] 

stack commented on HBASE-15638:
-------------------------------

Ok. Putting this aside for the moment. Let me upload latest. Am going to work on purge/narrowing our pb references in a sub issue next.

> Shade protobuf
> --------------
>
>                 Key: HBASE-15638
>                 URL: https://issues.apache.org/jira/browse/HBASE-15638
>             Project: HBase
>          Issue Type: Bug
>          Components: Protobufs
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>         Attachments: 15638v2.patch, HBASE-15638.master.001.patch, HBASE-15638.master.002.patch, HBASE-15638.master.003 (1).patch, HBASE-15638.master.003 (1).patch, HBASE-15638.master.003 (1).patch, HBASE-15638.master.003.patch, HBASE-15638.master.003.patch, HBASE-15638.master.004.patch, HBASE-15638.master.005.patch, HBASE-15638.master.006.patch, HBASE-15638.master.007.patch, HBASE-15638.master.007.patch, HBASE-15638.master.008.patch, as.far.as.server.patch
>
>
> Shade protobufs so we can move to a different version without breaking the world. We want to get up on pb3 because it has unsafe methods that allow us save on copies; it also has some means of dealing with BBs so we can pass it offheap DBBs. We'll probably want to change PB3 to open it up some more too so we can stay offheap as we traverse PB. This issue comes of [~anoop.hbase] and [~ram_krish]'s offheaping of the readpath work.
> This change is mostly straight-forward but there are some tricky bits:
>  # How to interface with HDFS? It wants its ByteStrings. Here in particular in FanOutOneBlockAsyncDFSOutputSaslHelper:
> {code}
>       if (payload != null) {
>         builder.setPayload(ByteString.copyFrom(payload));
>       }
> {code}
>  # [~busbey] also points out that we need to take care of endpoints done as pb. Test at least.
> Let me raise this one on the dev list too.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)