hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16272) Overflow in ServerName's compareTo method
Date Sat, 23 Jul 2016 08:41:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390625#comment-15390625
] 

Hudson commented on HBASE-16272:
--------------------------------

FAILURE: Integrated in HBase-1.1-JDK7 #1752 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1752/])
HBASE-16272 Overflow in ServerName's compareTo method (Huaxiang Sun) (matteo.bertozzi: rev
4f6647b9f0d089341d4aa9e693e421b2c89ac514)
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java


> Overflow in ServerName's compareTo method
> -----------------------------------------
>
>                 Key: HBASE-16272
>                 URL: https://issues.apache.org/jira/browse/HBASE-16272
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>             Fix For: 2.0.0, 1.3.0, 1.1.6, 0.98.21, 1.2.3
>
>         Attachments: HBASE-16272-v001.patch
>
>
> Looking at the ServerName's compareTo(), 
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java#L303
> It converts the return int value by converting long to int like (int)(longValue), which
could be incorrect when it overflows, need to replace it with Long.compareTo(a,b).
> [~mbertozzi] found some others as well, such as
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java#L990



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message