hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16272) Overflow in ServerName's compareTo method
Date Fri, 22 Jul 2016 22:22:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390296#comment-15390296
] 

huaxiang sun commented on HBASE-16272:
--------------------------------------

Manually run mvn clean test -Dtest=TestHRegion,TestMasterFailoverWithProcedure locally passed
for me.

> Overflow in ServerName's compareTo method
> -----------------------------------------
>
>                 Key: HBASE-16272
>                 URL: https://issues.apache.org/jira/browse/HBASE-16272
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>         Attachments: HBASE-16272-v001.patch
>
>
> Looking at the ServerName's compareTo(), 
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java#L303
> It converts the return int value by converting long to int like (int)(longValue), which
could be incorrect when it overflows, need to replace it with Long.compareTo(a,b).
> [~mbertozzi] found some others as well, such as
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java#L990



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message