hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16263) Move all to do w/ protobuf -- *.proto files and generated classes -- under hbase-protocol
Date Thu, 21 Jul 2016 15:57:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387936#comment-15387936
] 

Elliott Clark commented on HBASE-16263:
---------------------------------------

Yeah that doesn't sound worth it for such a small clean up.

+1 on the current patch.

> Move all to do w/ protobuf -- *.proto files and generated classes -- under hbase-protocol
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-16263
>                 URL: https://issues.apache.org/jira/browse/HBASE-16263
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: HBASE-16263.master.001.patch
>
>
> To better contain our protobuf exposure, keep all to do w/ protobuffing inside the hbase-protocol
module.
> This task moves rest, examples, and server proto files that do testing and CP endpoints
etc., under hbase-protocol. The patch is big but it is all just moving files.
> interesting to see the copy-paste being done everywhere of proto generation. For this
reason alone, it is better to have all the protos in the one place beside doc on how-to, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message