hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Yuan Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16243) Admin#takeSnapshotAsync should not expose Protos as the return type
Date Mon, 18 Jul 2016 23:04:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383254#comment-15383254
] 

Stephen Yuan Jiang commented on HBASE-16243:
--------------------------------------------

In the master branch, Admin#takeSnapshotAsync already return void?  

{code}
  @Override
  public void takeSnapshotAsync(SnapshotDescription snapshotDesc) throws IOException,
      SnapshotCreationException {
{code}

I know MasterProtos$SnapshotResponse has a timeout value inside; that is logic that you changed
the return type to long.  However, my question is that "is there any reason that we want to
return a different type as the master branch", because eventually HBASE-7912 branch would
merge with master branch?

> Admin#takeSnapshotAsync should not expose Protos as the return type
> -------------------------------------------------------------------
>
>                 Key: HBASE-16243
>                 URL: https://issues.apache.org/jira/browse/HBASE-16243
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>              Labels: backup
>         Attachments: 16243.v1.txt
>
>
> In HBASE-7912 branch, Admin#takeSnapshotAsync would trigger the following assertion:
> {code}
> 2016-07-18 14:53:56,908 INFO  [main] hbase.TestInterfaceAudienceAnnotations(340): These
are the methods that have Protos as the return type
> 2016-07-18 14:53:56,909 INFO  [main] hbase.TestInterfaceAudienceAnnotations(342): org.apache.hadoop.hbase.client.Admin
takeSnapshotAsync org.apache.hadoop.hbase.protobuf.generated.MasterProtos$SnapshotResponse
> {code}
> Admin#takeSnapshotAsync should not expose Protos as the return type



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message