hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16210) Add Timestamp class to the hbase-common
Date Wed, 20 Jul 2016 19:54:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386512#comment-15386512
] 

Hadoop QA commented on HBASE-16210:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 33s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 24s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 37s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s {color} |
{color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 30s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s {color} |
{color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 0m 39s {color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 31s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 32s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 1m 32s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s {color} |
{color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 30s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 1m 30s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 31m 19s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 8s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s {color} |
{color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 0m 40s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 0m 40s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 58s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 15s {color} | {color:green}
hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 56s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12819005/HBASE-16210.master.8.3.patch
|
| JIRA Issue | HBASE-16210 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  scalac  scaladoc  |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 70f330d |
| Default Java | 1.7.0_80 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 /home/jenkins/jenkins-slave/tools/hudson.model.JDK/JDK_1.7_latest_:1.7.0_80
|
| findbugs | v3.0.0 |
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2695/testReport/ |
| modules | C: hbase-common hbase-spark U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2695/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Add Timestamp class to the hbase-common
> ---------------------------------------
>
>                 Key: HBASE-16210
>                 URL: https://issues.apache.org/jira/browse/HBASE-16210
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sai Teja Ranuva
>            Assignee: Sai Teja Ranuva
>            Priority: Minor
>              Labels: patch, testing
>         Attachments: HBASE-16210.master.1.patch, HBASE-16210.master.2.patch, HBASE-16210.master.3.patch,
HBASE-16210.master.4.patch, HBASE-16210.master.5.patch, HBASE-16210.master.6.patch, HBASE-16210.master.7.patch,
HBASE-16210.master.8.1.patch, HBASE-16210.master.8.2.patch, HBASE-16210.master.8.3.patch,
HBASE-16210.master.8.patch
>
>
> This is a sub-issue of [HBase-14070|https://issues.apache.org/jira/browse/HBASE-14070].
This JIRA is a small step towards completely adding Hybrid Logical Clocks(HLC) to HBase. The
main idea of HLC is described in [HBase-14070|https://issues.apache.org/jira/browse/HBASE-14070]
along with the motivation of adding it to HBase. 
> This patch in this issue takes the code from the patch in the parent. 
> The parent patch is pretty big to review at once. So, plan is to get code reviewed in
smaller patches and 
> in the process take suggestions and change things if necessary. 
> What is this patch/issue about ?
> This issue attempts to add a timestamp class to hbase-common and timestamp type to HTable.

> This is a part of the attempt to get HLC into HBase. This patch does not interfere with
the current working of HBase.
> Why Timestamp Class ?
> Timestamp class can be as an abstraction to represent time in Hbase in 64 bits. 
> It is just used for manipulating with the 64 bits of the timestamp and is not concerned
about the actual time.
> There are three types of timestamps. System time, Custom and HLC. Each one of it has
methods to manipulate the 64 bits of timestamp. 
> HTable changes: Added a timestamp type property to HTable. This will help HBase exist
in conjunction with old type of timestamp and also the HLC which will be introduced. The default
is set to custom timestamp(current way of usage of timestamp). default unset timestamp is
also custom timestamp as it should be so. The default timestamp will be changed to HLC when
HLC feature is introduced completely in HBase.
> Check HBASE-16210.master.6.patch.
> Update: Based on the suggestions, made timestamp enum. Here is the description of the
new changes.
> Check the HBASE-16210.master.8.1.patch
> 1. Changed the Timestamp Implementation to Enum.
> 2. Changed the Timestamp semantics. Instead of HLC, System monotonic and custom, we now
have Hybrid and Physical. System monotonic clock and Custom clocks can map their timestamps
to Physical. HLC clock can map its timestamp to Hybrid.
> 3. The HTableDescriptor will contain clock type(not implemented yet) instead of timestamp
type. As clocks convey the semantics of monotonic increasing and non decreasing etc. TimestampType
doesn't have those semantics enforced, it just knows what to do with given 64 bits. Therefore,
I removed the timestamp type field in the HTableDescriptor.
> Open for suggestions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message