hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16195) Should not add chunk into chunkQueue if not using chunk pool in HeapMemStoreLAB
Date Mon, 11 Jul 2016 17:29:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371219#comment-15371219
] 

Anoop Sam John commented on HBASE-16195:
----------------------------------------

My point is that the fix that accounts duplicate cell's MSLAB size and the fix of not adding
the chunk into Q when MSLAB pool is OFF is enough to solve the bug. No need to limit the Q
size. What if we limit and need to add one more entry into Q? It will be problematic as we
will not return back that chunk to pool when that MSLAB is closed right? 
Ya my point is both these bugs fixes to ported by user.  My point is around the Q size limiting.
IMO that is not really needed and bug prone as said above. 

> Should not add chunk into chunkQueue if not using chunk pool in HeapMemStoreLAB
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-16195
>                 URL: https://issues.apache.org/jira/browse/HBASE-16195
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-16195.patch, HBASE-16195_v2.patch, HBASE-16195_v3.patch
>
>
> Problem description and analysis please refer to HBASE-16193



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message