hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16194) Should count in MSLAB chunk allocation into heap size change when adding duplicated cells
Date Fri, 08 Jul 2016 07:38:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367354#comment-15367354
] 

Yu Li commented on HBASE-16194:
-------------------------------

Actually in branch-1 code it's named as "notPresent" (see {{DefaultMemStore#internalAdd}})...
so IMHO the name {{succ}} is more explicitly indicating whether the add action succeeds and
don't interfere with the detailed logic. Thoughts? :-)

> Should count in MSLAB chunk allocation into heap size change when adding duplicated cells
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-16194
>                 URL: https://issues.apache.org/jira/browse/HBASE-16194
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 1.2.1, 1.1.5, 0.98.20
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-16194.patch, HBASE-16194_v2.patch
>
>
> See more details about problem description and analysis in HBASE-16193



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message