hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16172) Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas
Date Thu, 07 Jul 2016 15:04:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366240#comment-15366240
] 

Yu Li edited comment on HBASE-16172 at 7/7/16 3:04 PM:
-------------------------------------------------------

+1 on patch v4.

Checked {{TestHRegion}} in local and it could pass. {{TestReplicationSmallTests#testReplicationStatus}}
will also fail in local w/o patch here, so I don't think it's relative.


was (Author: carp84):
+1 on patch v4.

Checked the failed UT cases {{TestHRegion}} and {{TestReplicationSmallTests#testReplicationStatus}}
in local and all could pass.

> Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16172
>                 URL: https://issues.apache.org/jira/browse/HBASE-16172
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Ted Yu
>         Attachments: 16172.v1.txt, 16172.v2.txt, 16172.v2.txt, 16172.v3.txt, 16172.v4.txt
>
>
> The issue is pointed out by [~devaraj] in HBASE-16132 (Thanks D.D.), that in {{RpcRetryingCallerWithReadReplicas#call}}
we will call {{ResultBoundedCompletionService#take}} instead of {{poll}} to dead-wait on the
second one if the first replica timed out, while in {{ScannerCallableWithReplicas#call}} we
still use {{ResultBoundedCompletionService#poll}} with some timeout for the 2nd replica.
> This JIRA aims at discussing whether to unify the logic in these two kinds of caller
with region replica and taking action if necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message