hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16172) Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas
Date Tue, 05 Jul 2016 09:38:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362282#comment-15362282
] 

Heng Chen commented on HBASE-16172:
-----------------------------------

+1 for unify them.  And IMO we should respect "timeout" in RpcRetryingCallerWithReadReplicas#call.


> Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16172
>                 URL: https://issues.apache.org/jira/browse/HBASE-16172
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>
> The issue is pointed out by [~devaraj] in HBASE-16132 (Thanks D.D.), that in {{RpcRetryingCallerWithReadReplicas#call}}
we will call {{ResultBoundedCompletionService#take}} instead of {{poll}} to dead-wait on the
second one if the first replica timed out, while in {{ScannerCallableWithReplicas#call}} we
still use {{ResultBoundedCompletionService#poll}} with some timeout for the 2nd replica.
> This JIRA aims at discussing whether to unify the logic in these two kinds of caller
with region replica and taking action if necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message