hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Rodionov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15988) Backup set add command MUST initiate full backup for a table(s) being added
Date Thu, 07 Jul 2016 01:06:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365434#comment-15365434
] 

Vladimir Rodionov commented on HBASE-15988:
-------------------------------------------

No check if tables in tableList have all full backup. This check used to be before.

This is the current code. [~tedyu], as you can see, we do not check if tableList is fully
covered by incrTableSet. Means, all tables
from tableList have backups already.

{code}
  public Pair<Long, String> backupTables(final BackupType type,
        List<TableName> tableList, final String targetRootDir, final int workers,
        final long bandwidth) throws IOException {
    long procId;
    String backupId = BackupRestoreConstants.BACKUPID_PREFIX + 
        EnvironmentEdgeManager.currentTime();
    if (type == BackupType.INCREMENTAL) {
      Set<TableName> incrTableSet = null;
      try (BackupSystemTable table = new BackupSystemTable(getConnection())) {
        incrTableSet = table.getIncrementalBackupTableSet(targetRootDir);
      }
         
      if (incrTableSet.isEmpty()) {
        LOG.warn("Incremental backup table set contains no table.\n"
            + "Use 'backup create full' or 'backup stop' to \n "
            + "change the tables covered by incremental backup.");
        throw new DoNotRetryIOException("No table covered by incremental backup.");
      }

      LOG.info("Incremental backup for the following table set: " + incrTableSet);
      tableList = Lists.newArrayList(incrTableSet);
    }
{code}

That should be fixed in a separate JIRA. As for the current, as I pointed that out already,
the proposed implementation will be the source of confusion. We can not postpone failure until
first backup run. Operation of adding table to backup set should either fail or succeed immediately.

> Backup set add command MUST initiate full backup for a table(s) being added
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-15988
>                 URL: https://issues.apache.org/jira/browse/HBASE-15988
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: 15988.v1.txt, 15988.v2.txt, 15988.v3.txt
>
>
> When a new table is added to backup table set, the incremental backup involving the new
table should be full backup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message