hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15844) We should respect hfile.block.index.cacheonwrite when write intermediate index Block
Date Fri, 01 Jul 2016 04:03:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358345#comment-15358345
] 

Anoop Sam John commented on HBASE-15844:
----------------------------------------

That make sense.  Seems a miss while coding.. Ya when cache on write is true and we cache
leaf and intermediate level blocks, there is no point not caching Root.  Actually Root should
get more priority.   Better correct here only?

> We should respect hfile.block.index.cacheonwrite when write intermediate index Block
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15844
>                 URL: https://issues.apache.org/jira/browse/HBASE-15844
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15844.patch
>
>
> {code: title=BlockIndexWriter#writeIntermediateBlock}
>       if (cacheConf != null) {
>         HFileBlock blockForCaching = blockWriter.getBlockForCaching(cacheConf);
>         cacheConf.getBlockCache().cacheBlock(new BlockCacheKey(nameForCaching,
>           beginOffset, true, blockForCaching.getBlockType()), blockForCaching);
>       }
> {code}
> The if condition should be ?
> {code}
> if (cacheConf != null && cacheConf.shouldCacheIndexesOnWrite()) 
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message