hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15844) We should respect hfile.block.index.cacheonwrite when write intermediate index Block
Date Fri, 01 Jul 2016 05:16:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358405#comment-15358405
] 

Heng Chen commented on HBASE-15844:
-----------------------------------

OK. Let's commit it to branch-1 and master

> We should respect hfile.block.index.cacheonwrite when write intermediate index Block
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15844
>                 URL: https://issues.apache.org/jira/browse/HBASE-15844
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-15844.patch, HBASE-15844_v1.patch
>
>
> {code: title=BlockIndexWriter#writeIntermediateBlock}
>       if (cacheConf != null) {
>         HFileBlock blockForCaching = blockWriter.getBlockForCaching(cacheConf);
>         cacheConf.getBlockCache().cacheBlock(new BlockCacheKey(nameForCaching,
>           beginOffset, true, blockForCaching.getBlockType()), blockForCaching);
>       }
> {code}
> The if condition should be ?
> {code}
> if (cacheConf != null && cacheConf.shouldCacheIndexesOnWrite()) 
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message