hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15638) Shade protobuf
Date Thu, 28 Jul 2016 13:01:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397500#comment-15397500
] 

Hadoop QA commented on HBASE-15638:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 73 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 50s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 45s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 9s {color} | {color:green}
master passed with JDK v1.7.0_25 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 38m 29s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 9m 10s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 5m 35s {color}
| {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue}
Skipped branch modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 26s {color} | {color:red}
hbase-protocol in master has 93 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 39s {color} | {color:red}
hbase-rsgroup in master has 6 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 49s {color} | {color:red}
hbase-rest in master has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 41s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 26s {color} |
{color:green} master passed with JDK v1.7.0_25 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 49s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 19s {color} | {color:red}
root in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 1m 19s {color} | {color:red}
root in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 19s {color} | {color:red}
root in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 45s {color} | {color:red}
root in the patch failed with JDK v1.7.0_25. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 45s {color} | {color:red}
root in the patch failed with JDK v1.7.0_25. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 26m 36s {color} | {color:red}
hbase-common-jdk1.7.0_25 with JDK v1.7.0_25 generated 1 new + 25 unchanged - 1 fixed = 26
total (was 26) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 45s {color} | {color:red}
root in the patch failed with JDK v1.7.0_25. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 37m 41s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m 59s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 45m 40s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 6m 21s {color}
| {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue}
Skipped patch modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 55s {color} |
{color:green} hbase-protocol generated 0 new + 0 unchanged - 93 fixed = 0 total (was 93) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 23s {color} |
{color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 53s {color} |
{color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 38s {color} |
{color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 8s {color} |
{color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 57s {color} |
{color:green} hbase-rsgroup generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 56s {color} |
{color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 6s {color} |
{color:green} hbase-rest generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 18s {color} |
{color:green} hbase-spark in the patch passed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 38s {color} | {color:red}
hbase-client-jdk1.8.0 with JDK v1.8.0 generated 87 new + 13 unchanged - 0 fixed = 100 total
(was 13) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 38s {color} | {color:red}
hbase-server-jdk1.8.0 with JDK v1.8.0 generated 6 new + 1 unchanged - 0 fixed = 7 total (was
1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 39s {color} | {color:red}
root-jdk1.8.0 with JDK v1.8.0 generated 105 new + 19 unchanged - 0 fixed = 124 total (was
19) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 19s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 17m 51s {color} | {color:red}
hbase-client-jdk1.7.0_25 with JDK v1.7.0_25 generated 114 new + 13 unchanged - 0 fixed = 127
total (was 13) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 17m 51s {color} | {color:red}
hbase-server-jdk1.7.0_25 with JDK v1.7.0_25 generated 6 new + 1 unchanged - 0 fixed = 7 total
(was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 17m 52s {color} | {color:red}
root-jdk1.7.0_25 with JDK v1.7.0_25 generated 120 new + 24 unchanged - 0 fixed = 144 total
(was 24) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 10s {color} |
{color:green} the patch passed with JDK v1.7.0_25 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 42s {color} | {color:green}
hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 51s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 44s {color} | {color:green}
hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 43s {color} | {color:red}
hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 125m 42s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 45s {color} | {color:green}
hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 34s {color} | {color:green}
hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s {color} | {color:green}
hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m 25s {color} | {color:green}
hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 34s {color} | {color:green}
hbase-spark in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 7s {color} | {color:red}
root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 5s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 409m 9s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
|   | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures |
|   | hadoop.hbase.TestInterfaceAudienceAnnotations |
|   | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures |
| Timed out junit tests | org.apache.hadoop.hbase.security.access.TestAccessController2 |
|   | org.apache.hadoop.hbase.security.access.TestAccessController |
|   | org.apache.hadoop.hbase.security.access.TestTablePermissions |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12820646/HBASE-15638.master.007.patch
|
| JIRA Issue | HBASE-15638 |
| Optional Tests |  asflicense  findbugs  xml  javac  javadoc  unit  hadoopcheck  hbaseanti
 checkstyle  compile  cc  hbaseprotoc  |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 00c2a5d |
| Default Java | 1.7.0_25 |
| Multi-JDK versions |  /usr/local/jenkins/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_25-64:1.7.0_25
|
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/branch-findbugs-hbase-protocol-warnings.html
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.8.0.txt
|
| cc | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.8.0.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.8.0.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.7.0_25.txt
|
| cc | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.7.0_25.txt
|
| javac | hbase-common-jdk1.7.0_25: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-compile-javac-hbase-common-jdk1.7.0_25.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-compile-root-jdk1.7.0_25.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/whitespace-eol.txt
|
| javadoc | hbase-client-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0.txt
|
| javadoc | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt
|
| javadoc | root-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.8.0.txt
|
| javadoc | hbase-client-jdk1.7.0_25: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_25.txt
|
| javadoc | hbase-server-jdk1.7.0_25: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_25.txt
|
| javadoc | root-jdk1.7.0_25: https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.7.0_25.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-root.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-hbase-client.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-hbase-server.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/2803/artifact/patchprocess/patch-unit-root.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/testReport/ |
| modules | C: hbase-protocol hbase-common hbase-procedure hbase-client hbase-server hbase-rsgroup
hbase-it hbase-examples hbase-rest hbase-spark . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2803/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Shade protobuf
> --------------
>
>                 Key: HBASE-15638
>                 URL: https://issues.apache.org/jira/browse/HBASE-15638
>             Project: HBase
>          Issue Type: Bug
>          Components: Protobufs
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>         Attachments: 15638v2.patch, HBASE-15638.master.001.patch, HBASE-15638.master.002.patch,
HBASE-15638.master.003 (1).patch, HBASE-15638.master.003 (1).patch, HBASE-15638.master.003
(1).patch, HBASE-15638.master.003.patch, HBASE-15638.master.003.patch, HBASE-15638.master.004.patch,
HBASE-15638.master.005.patch, HBASE-15638.master.006.patch, HBASE-15638.master.007.patch,
HBASE-15638.master.007.patch, HBASE-15638.master.008.patch, as.far.as.server.patch
>
>
> Shade protobufs so we can move to a different version without breaking the world. We
want to get up on pb3 because it has unsafe methods that allow us save on copies; it also
has some means of dealing with BBs so we can pass it offheap DBBs. We'll probably want to
change PB3 to open it up some more too so we can stay offheap as we traverse PB. This issue
comes of [~anoop.hbase] and [~ram_krish]'s offheaping of the readpath work.
> This change is mostly straight-forward but there are some tricky bits:
>  # How to interface with HDFS? It wants its ByteStrings. Here in particular in FanOutOneBlockAsyncDFSOutputSaslHelper:
> {code}
>       if (payload != null) {
>         builder.setPayload(ByteString.copyFrom(payload));
>       }
> {code}
>  # [~busbey] also points out that we need to take care of endpoints done as pb. Test
at least.
> Let me raise this one on the dev list too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message