hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anastasia Braginsky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14921) Memory optimizations
Date Tue, 19 Jul 2016 13:01:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384110#comment-15384110
] 

Anastasia Braginsky commented on HBASE-14921:
---------------------------------------------

First, thanks everybody for the code review comments! And special thanks to [~anoop.hbase]
for the thoroughly review!

One question to [~ram_krish], I am looking on your comment:
bq. I think it is already there. But this scanner will not deal with deletes, only if there
are duplicate versions will be removed.
related to the following line in the MemStoreCompactorIterator:
{code}
   /**
   * Creates the scanner for compacting the pipeline.
   *
   * @return the scanner
   */
  private StoreScanner createScanner(Store store, KeyValueScanner scanner)   throws IOException
{
    Scan scan = new Scan();
    scan.setMaxVersions();  //Get all available versions
    StoreScanner internalScanner =
        new StoreScanner(store, store.getScanInfo(), scan, Collections.singletonList(scanner),
            ScanType.COMPACT_RETAIN_DELETES, store.getSmallestReadPoint(),      //<<<<<
this is the line
            HConstants.OLDEST_TIMESTAMP);
    return internalScanner;
  }
{code}

Can we do anything better? It looks like we will never able to deal with deletion, because
this compaction is always minor. Or am I wrong?


> Memory optimizations
> --------------------
>
>                 Key: HBASE-14921
>                 URL: https://issues.apache.org/jira/browse/HBASE-14921
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Eshcar Hillel
>            Assignee: Anastasia Braginsky
>         Attachments: CellBlocksSegmentInMemStore.pdf, CellBlocksSegmentinthecontextofMemStore(1).pdf,
HBASE-14921-V01.patch, HBASE-14921-V02.patch, HBASE-14921-V03.patch, HBASE-14921-V04-CA-V02.patch,
HBASE-14921-V04-CA.patch, HBASE-14921-V05-CAO.patch, InitialCellArrayMapEvaluation.pdf, IntroductiontoNewFlatandCompactMemStore.pdf
>
>
> Memory optimizations including compressed format representation and offheap allocations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message