hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14881) Provide a Put API that uses the provided row without coping
Date Sat, 30 Jul 2016 15:31:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400708#comment-15400708
] 

Anoop Sam John commented on HBASE-14881:
----------------------------------------

{code}
} else {  // Row is not immutable
154	      // Make a local copy
155	      checkRow(row, 0, row.length);
{code}
checkRow() done twice for else case.  We can remove.  
+1
I can fix this issue on commit. No need for new patch.

> Provide a Put API that uses the provided row without coping
> -----------------------------------------------------------
>
>                 Key: HBASE-14881
>                 URL: https://issues.apache.org/jira/browse/HBASE-14881
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Jerry He
>            Assignee: Xiang Li
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14881-master-v0.patch, HBASE-14881.master.001.patch, HBASE-14881.master.002.patch
>
>
> The current available Put API always makes a copy of the rowkey.
> Let's provide an API that accepts an immutable byte array as rowkey without making a
copy.
> There are cases where the caller of Put has created the immutable byte array (e.g from
a serializer) and will not change it for the Put duration. We can avoid making a copy again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message