Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1C1DD200B44 for ; Thu, 30 Jun 2016 07:29:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1AA14160A6F; Thu, 30 Jun 2016 05:29:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 62E96160A57 for ; Thu, 30 Jun 2016 07:29:11 +0200 (CEST) Received: (qmail 55449 invoked by uid 500); 30 Jun 2016 05:29:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 55412 invoked by uid 99); 30 Jun 2016 05:29:10 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2016 05:29:10 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1A4982C027F for ; Thu, 30 Jun 2016 05:29:10 +0000 (UTC) Date: Thu, 30 Jun 2016 05:29:10 +0000 (UTC) From: "Jerry He (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-16149) Log the underlying RPC exception in RpcRetryingCallerImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Jun 2016 05:29:12 -0000 Jerry He created HBASE-16149: -------------------------------- Summary: Log the underlying RPC exception in RpcRetryingCallerImpl Key: HBASE-16149 URL: https://issues.apache.org/jira/browse/HBASE-16149 Project: HBase Issue Type: Improvement Affects Versions: 1.2.0 Reporter: Jerry He Assignee: Jerry He Priority: Minor In RpcRetryingCallerImpl: {code} public T callWithRetries(RetryingCallable callable, int callTimeout) throws IOException, RuntimeException { ... for (int tries = 0;; tries++) { try { ... return callable.call(getTimeout(callTimeout)); ... } catch (Throwable t) { ExceptionUtil.rethrowIfInterrupt(t); if (tries > startLogErrorsCnt) { LOG.info("Call exception, tries=" + tries + ", maxAttempts=" + maxAttempts + ", started=" + (EnvironmentEdgeManager.currentTime() - tracker.getStartTime()) + " ms ago, " + "cancelled=" + cancelled.get() + ", msg=" + callable.getExceptionMessageAdditionalDetail()); } ... {code} We log the callable.getExceptionMessageAdditionalDetail() msg. But callable.getExceptionMessageAdditionalDetail() may not provide the underlying cause.. For example, in AbstractRegionServerCallable, {code} public String getExceptionMessageAdditionalDetail() { return "row '" + Bytes.toString(row) + "' on table '" + tableName + "' at " + location; } {code} Let's add the underlying exception cause to the message as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)