Return-Path: <issues-return-249114-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id AF146200B33
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 29 Jun 2016 09:07:47 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id A2F0F160A57; Wed, 29 Jun 2016 07:07:47 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id EBA5F160A4D
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 29 Jun 2016 09:07:46 +0200 (CEST)
Received: (qmail 21401 invoked by uid 500); 29 Jun 2016 07:07:45 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 21390 invoked by uid 99); 29 Jun 2016 07:07:45 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jun 2016 07:07:45 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8D9872C02A0
	for <issues@hbase.apache.org>; Wed, 29 Jun 2016 07:07:45 +0000 (UTC)
Date: Wed, 29 Jun 2016 07:07:45 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12984784.1467181853000.1882.1467184065576@Atlassian.JIRA>
In-Reply-To: <JIRA.12984784.1467181853000@Atlassian.JIRA>
References: <JIRA.12984784.1467181853000@Atlassian.JIRA> <JIRA.12984784.1467181853850@arcas>
Subject: [jira] [Commented] (HBASE-16143) Change MemstoreScanner constructor
 to accept List<KeyValueScanner>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 29 Jun 2016 07:07:47 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354706#comment-15354706 ] 

ramkrishna.s.vasudevan commented on HBASE-16143:
------------------------------------------------

Thanks for the quick review.
bq.Call it getScanners() No need to say data structure name in method name
I could see that there is already a getScanners() API and getListOfScanners() is also something similar.
bq.Make the type as List and new ArrayList? Dont think we need a LinkedList anyway.
Lets see. May be yes.
I think we could do more clean up in SegmentScanner. Will do in this patch only then.

> Change MemstoreScanner constructor to accept List<KeyValueScanner>
> ------------------------------------------------------------------
>
>                 Key: HBASE-16143
>                 URL: https://issues.apache.org/jira/browse/HBASE-16143
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16143.patch
>
>
> A minor change that helps in creating a memstore that avoids the compaction process and just allows to creates a pipeline of segments and on flush directly reads the segments in the pipeline and flushes it out after creating a snapshot of the pipeline. Based on test results and updated patch on HBASE-14921 (to be provided) will see how much flattening helps us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)