Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 21 Jun 2016 20:09:58 +0000 (UTC)
From: "Elliott Clark (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12979505.1466018844000.14808.1466539798041@Atlassian.JIRA>
In-Reply-To: <JIRA.12979505.1466018844000@Atlassian.JIRA>
References: <JIRA.12979505.1466018844000@Atlassian.JIRA> <JIRA.12979505.1466018844481@arcas>
Subject: [jira] [Updated] (HBASE-16036) Fix ReplicationTableBase
 initialization to make it non-blocking
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 21 Jun 2016 20:10:00 -0000


     [ https://issues.apache.org/jira/browse/HBASE-16036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliott Clark updated HBASE-16036:
----------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.0.0
           Status: Resolved  (was: Patch Available)

Pushed to master.

> Fix ReplicationTableBase initialization to make it non-blocking
> ---------------------------------------------------------------
>
>                 Key: HBASE-16036
>                 URL: https://issues.apache.org/jira/browse/HBASE-16036
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Joseph
>            Assignee: Joseph
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16036.patch
>
>
> Currently there is a bug inside of TableBasedReplicationQueuesImpl construction that prevents ReplicationServices from starting before Master is initialized. So currently each of the RS, including HMaster, with Replication enabled will attempt to create the ReplicationTable on initialization. 
> Currently HMaster's initialization: serviceThreads.start() -> new TableBasedReplicationQueuesImpl() -> Replication Table Creation -> HMaster sets initialized flags.
> But this fails when we try to create the Replication Table as the HMaster.checkInitialized() flag fails. This ends up blocking HMaster initialization and results in a deadlock.
> So in this patch, I will create the Replication Table in the background of TableBasedReplicationQueuesImpl and only block when we actually call methods that access it.
> This also requires a small refactoring of ReplicationSourceManager.init() so that we run the abandoned queue adoption in the background
> Review board at: https://reviews.apache.org/r/48763/


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)