Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 15 Jun 2016 22:29:09 +0000 (UTC)
From: "Joseph (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12979505.1466018844000.12085.1466029749659@Atlassian.JIRA>
In-Reply-To: <JIRA.12979505.1466018844000@Atlassian.JIRA>
References: <JIRA.12979505.1466018844000@Atlassian.JIRA> <JIRA.12979505.1466018844481@arcas>
Subject: [jira] [Commented] (HBASE-16036) Fix ReplicationQueuesHBaseImpl
 initialization non-blocking
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Jun 2016 22:36:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332754#comment-15332754 ] 

Joseph commented on HBASE-16036:
--------------------------------

Sorry I think the previously posted reviews.apache was based on an older commit of Master. I've posted up a newer review in the description.

> Fix ReplicationQueuesHBaseImpl initialization non-blocking
> ----------------------------------------------------------
>
>                 Key: HBASE-16036
>                 URL: https://issues.apache.org/jira/browse/HBASE-16036
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Joseph
>            Assignee: Joseph
>         Attachments: HBASE-16036.patch
>
>
> Currently there is a bug inside of TableBasedReplicationQueuesImpl construction that prevents ReplicationServices from starting before Master is initialized. So currently each of the RS, including HMaster, with Replication enabled will attempt to create the ReplicationTable on initialization. 
> Currently HMaster's initialization: serviceThreads.start() -> new TableBasedReplicationQueuesImpl() -> Replication Table Creation -> HMaster sets initialized flags.
> But this fails when we try to create the Replication Table as the HMaster.checkInitialized() flag fails. This ends up blocking HMaster initialization and results in a deadlock.
> So in this patch, I will create the Replication Table in the background of TableBasedReplicationQueuesImpl and only block when we actually call methods that access it.
> This also requires a small refactoring of ReplicationSourceManager.init() so that we run the abandoned queue adoption in the background
> Review board at: https://reviews.apache.org/r/48763/


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)