Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3FD13200B29 for ; Wed, 15 Jun 2016 20:32:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3E924160A19; Wed, 15 Jun 2016 18:32:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B608E160A5D for ; Wed, 15 Jun 2016 20:32:10 +0200 (CEST) Received: (qmail 49467 invoked by uid 500); 15 Jun 2016 18:32:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 49361 invoked by uid 99); 15 Jun 2016 18:32:09 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jun 2016 18:32:09 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C554C2C14F9 for ; Wed, 15 Jun 2016 18:32:09 +0000 (UTC) Date: Wed, 15 Jun 2016 18:32:09 +0000 (UTC) From: "Dima Spivak (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16034) Fix ProcedureTestingUtility#LoadCounter.setMaxProcId() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Jun 2016 18:32:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332277#comment-15332277 ] Dima Spivak commented on HBASE-16034: ------------------------------------- Is your working dir clean? The fix of maxProcId looks good, but the patch you posted looks like it's modifying code that's not pushed yet ({{restartAndAssert}}). > Fix ProcedureTestingUtility#LoadCounter.setMaxProcId() > ------------------------------------------------------- > > Key: HBASE-16034 > URL: https://issues.apache.org/jira/browse/HBASE-16034 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, test > Affects Versions: 2.0.0, 1.3.0, 1.2.1 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.2.2 > > Attachments: HBASE-16034-v0.patch > > > ProcedureTestingUtility LoadCounter.setMaxProcId() implementation is wrong, and it ends up not setting the max value > {code} > public void setMaxProcId(long maxProcId) { > - maxProcId = maxProcId; > + this.maxProcId = maxProcId; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)