Return-Path: <issues-return-247812-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id E308F200B30
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 20 Jun 2016 03:55:07 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id E165D160A64; Mon, 20 Jun 2016 01:55:07 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 357CB160A53
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 20 Jun 2016 03:55:07 +0200 (CEST)
Received: (qmail 40489 invoked by uid 500); 20 Jun 2016 01:55:06 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 40471 invoked by uid 99); 20 Jun 2016 01:55:06 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2016 01:55:06 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 1635C2C1F6A
	for <issues@hbase.apache.org>; Mon, 20 Jun 2016 01:55:06 +0000 (UTC)
Date: Mon, 20 Jun 2016 01:55:06 +0000 (UTC)
From: "Hiroshi Ikeda (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12979054.1465927664000.40160.1466387706088@Atlassian.JIRA>
In-Reply-To: <JIRA.12979054.1465927664000@Atlassian.JIRA>
References: <JIRA.12979054.1465927664000@Atlassian.JIRA> <JIRA.12979054.1465927664075@arcas>
Subject: [jira] [Commented] (HBASE-16023) Fastpath for the FIFO rpcscheduler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 20 Jun 2016 01:55:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338883#comment-15338883 ] 

Hiroshi Ikeda commented on HBASE-16023:
---------------------------------------

Other worrying things:

{code}
    protected CallRunner getCallRunner() throws InterruptedException {
...skip...
        if (this.fastPathHandlerStack != null) {
          this.fastPathHandlerStack.push(this);
          this.semaphore.acquire();
          cr = this.loadedCallRunner;
        } else {
{code}

The loadedCallRunner should be set to null after passing, otherwise that would become sort of memory leak (in low load).


It is not a bug but
{code}
    private Semaphore semaphore = new Semaphore(1);
...skip...
    FastPathHandler(String name, double handlerFailureThreshhold, BlockingQueue<CallRunner> q,
...skip...
      this.semaphore.drainPermits();
{code}

It is better to just create an instance of Semaphore with no permit.

> Fastpath for the FIFO rpcscheduler
> ----------------------------------
>
>                 Key: HBASE-16023
>                 URL: https://issues.apache.org/jira/browse/HBASE-16023
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance, rpc
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16023.addenum.patch, HBASE-16023.branch-1.001.patch, hits.nofifo.fifoplusfp.fifownofp.hacks.png
>
>
> This is an idea copied from kudu where we skip queuing a request if there is a handler ready to go; we just do a direct handoff from reader to handler.
> Makes for close to a %20 improvement in random read workloadc testing moving the bottleneck to HBASE-15716 and to returning the results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)