Return-Path: <issues-return-246593-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C77C8200B2B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 13 Jun 2016 18:27:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id C631D160A1A; Mon, 13 Jun 2016 16:27:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1E84D160A3C
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 13 Jun 2016 18:27:21 +0200 (CEST)
Received: (qmail 70961 invoked by uid 500); 13 Jun 2016 16:27:21 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 70850 invoked by uid 99); 13 Jun 2016 16:27:21 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 16:27:21 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 135BB2C1F61
	for <issues@hbase.apache.org>; Mon, 13 Jun 2016 16:27:21 +0000 (UTC)
Date: Mon, 13 Jun 2016 16:27:21 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12977786.1465600472000.71516.1465835241076@Atlassian.JIRA>
In-Reply-To: <JIRA.12977786.1465600472000@Atlassian.JIRA>
References: <JIRA.12977786.1465600472000@Atlassian.JIRA> <JIRA.12977786.1465600472195@arcas>
Subject: [jira] [Commented] (HBASE-16010) Put draining function through
 Admin API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 13 Jun 2016 16:27:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327694#comment-15327694 ] 

Matteo Bertozzi commented on HBASE-16010:
-----------------------------------------

how does the getDrainingRegions() works? doesn't this just turn out to be getOnlineRegions(ServerName)? I don't remember anything in the AM or ServerManager that keeps track of regions moving because of the server in the draining list.

or was the method supposed to be a List<ServerName> getDrainingRegionServers()? which is what the ServerManager.getDrainingServersList()?

(pretty sure that you already know this, but just to make it clear. we need to also add Master RPCs if we want to add support for secure clusters and ACLs. and we probably need to have a fallback to zk calls if the client is new but the server is old to keep compat, at least in branch-1)

> Put draining function through Admin API
> ---------------------------------------
>
>                 Key: HBASE-16010
>                 URL: https://issues.apache.org/jira/browse/HBASE-16010
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Matt Warhaftig
>            Priority: Minor
>
> Currently, there is no Amdin API for draining function. Client has to interact directly with Zookeeper draining node to add and remove draining servers.
> For example, in draining_servers.rb:
> {code}
>   zkw = org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.new(config, "draining_servers", nil)
>   parentZnode = zkw.drainingZNode
>   begin
>     for server in servers
>       node = ZKUtil.joinZNode(parentZnode, server)
>       ZKUtil.createAndFailSilent(zkw, node)
>     end
>   ensure
>     zkw.close()
>   end
> {code}
> This is not good in cases like secure clusters with protected Zookeeper nodes.
> Let's put draining function through Admin API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)