Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A28D8200AF6 for ; Sat, 11 Jun 2016 21:14:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A1237160A34; Sat, 11 Jun 2016 19:14:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E7E75160A2B for ; Sat, 11 Jun 2016 21:14:21 +0200 (CEST) Received: (qmail 60897 invoked by uid 500); 11 Jun 2016 19:14:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 60873 invoked by uid 99); 11 Jun 2016 19:14:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2016 19:14:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EACF12C1F54 for ; Sat, 11 Jun 2016 19:14:20 +0000 (UTC) Date: Sat, 11 Jun 2016 19:14:20 +0000 (UTC) From: "Anastasia Braginsky (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15991) CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 11 Jun 2016 19:14:22 -0000 [ https://issues.apache.org/jira/browse/HBASE-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326015#comment-15326015 ] Anastasia Braginsky commented on HBASE-15991: --------------------------------------------- The change looks reasonable for me. > CompactingMemstore#InMemoryFlushRunnable should implement Comparable/Comparator > ------------------------------------------------------------------------------- > > Key: HBASE-15991 > URL: https://issues.apache.org/jira/browse/HBASE-15991 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-15991.patch, HBASE-15991_test.patch > > > Configuring CompactingMemstore for a table fails due to the following error > {code} > 2016-06-08 23:27:03,761 ERROR [B.defaultRpcServer.handler... > 2016-06-08 23:27:03,761 ERROR [B.defaultRpcServer.handler=38,queue=8,port=16041] ipc.RpcServer: Unexpected throwable object > java.lang.ClassCastException: org.apache.hadoop.hbase.regionserver.CompactingMemStore$InMemoryFlushRunnable cannot be cast to java.lang.Comparable > at java.util.concurrent.PriorityBlockingQueue.siftUpComparable(PriorityBlockingQueue.java:357) > at java.util.concurrent.PriorityBlockingQueue.offer(PriorityBlockingQueue.java:489) > at org.apache.hadoop.hbase.util.StealJobQueue$1.offer(StealJobQueue.java:56) > at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1361) > at org.apache.hadoop.hbase.regionserver.CompactingMemStore.checkActiveSize(CompactingMemStore.java:258) > at org.apache.hadoop.hbase.regionserver.AbstractMemStore.internalAdd(AbstractMemStore.java:403) > at org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:113) > at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:630) > at org.apache.hadoop.hbase.regionserver.HRegion.applyToMemstore(HRegion.java:3769) > at org.apache.hadoop.hbase.regionserver.HRegion.applyFamilyMapToMemstore(HRegion.java:3740) > at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:3222) > at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2954) > at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2896) > at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:868) > at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:830) > at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2307) > at org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:34826) > {code} > It is a straight forward fix. But If we implement the Comparable the compareTo() should be based on what attribute? Should be based on the time? -- This message was sent by Atlassian JIRA (v6.3.4#6332)