Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 28823200B32 for ; Thu, 9 Jun 2016 02:19:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 271BE160A58; Thu, 9 Jun 2016 00:19:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71EAD160A35 for ; Thu, 9 Jun 2016 02:19:22 +0200 (CEST) Received: (qmail 35225 invoked by uid 500); 9 Jun 2016 00:19:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 34757 invoked by uid 99); 9 Jun 2016 00:19:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 00:19:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 118802C1F69 for ; Thu, 9 Jun 2016 00:19:21 +0000 (UTC) Date: Thu, 9 Jun 2016 00:19:21 +0000 (UTC) From: "huaxiang sun (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15959) Fix flaky test TestRegionServerMetrics.testMobMetrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Jun 2016 00:19:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321688#comment-15321688 ] huaxiang sun commented on HBASE-15959: -------------------------------------- I checked the code, that is the only one which store.close() needs to be added. I updated the comments, a new diff attached, thanks. > Fix flaky test TestRegionServerMetrics.testMobMetrics > ----------------------------------------------------- > > Key: HBASE-15959 > URL: https://issues.apache.org/jira/browse/HBASE-15959 > Project: HBase > Issue Type: Bug > Reporter: Appy > Assignee: huaxiang sun > Attachments: HBASE-15959-v001.patch, HBASE-15959-v002.patch, HBASE-15959-v003.patch, HBASE-15959-v004.patch, HBASE-15959-v005.patch > > > It flakes [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java#L460]. > There are two weird things i identified: > 1. In second compaction, [scanner|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L173] has 10 storefiles. Shouldn't there be 6? 5 from recent flushes and 1 from earlier compaction. Probably because mob cleaner doesn't clean old hfiles. Does this needs fixing? > 2. Across runs, same cell (ie. same key) may or may not be considered mob reference cell. [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L213]. This at least happens with row keys 0 - 4 (which got compacted earlier). [~jmhsieh] Any ideas why this would happen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)