Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D93EE2009F8 for ; Fri, 3 Jun 2016 23:05:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D80D3160A50; Fri, 3 Jun 2016 21:05:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 23BE5160A49 for ; Fri, 3 Jun 2016 23:04:59 +0200 (CEST) Received: (qmail 87466 invoked by uid 500); 3 Jun 2016 21:04:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 87433 invoked by uid 99); 3 Jun 2016 21:04:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 21:04:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2E6952C1F5C for ; Fri, 3 Jun 2016 21:04:59 +0000 (UTC) Date: Fri, 3 Jun 2016 21:04:59 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15949) Cleanup TestRegionServerMetrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Jun 2016 21:05:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314806#comment-15314806 ] Andrew Purtell commented on HBASE-15949: ---------------------------------------- +1 > Cleanup TestRegionServerMetrics > ------------------------------- > > Key: HBASE-15949 > URL: https://issues.apache.org/jira/browse/HBASE-15949 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Priority: Minor > Attachments: HBASE-15949.master.001.patch > > > Had a go through TestRegionServerMetrics when looking at HBASE-15929. > Patch to use > - @Before and @After to setup/teardown tables using @Rule to set table name based on testname. > - Refactor out copy-pasted code fragments to single function. -- This message was sent by Atlassian JIRA (v6.3.4#6332)