Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CD3E6200B0F for ; Fri, 3 Jun 2016 08:08:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CBEF6160A52; Fri, 3 Jun 2016 06:08:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 45F18160A51 for ; Fri, 3 Jun 2016 08:08:00 +0200 (CEST) Received: (qmail 989 invoked by uid 500); 3 Jun 2016 06:07:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 973 invoked by uid 99); 3 Jun 2016 06:07:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 06:07:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2780A2C1F60 for ; Fri, 3 Jun 2016 06:07:59 +0000 (UTC) Date: Fri, 3 Jun 2016 06:07:59 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15879) Introduce Key interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Jun 2016 06:08:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-15879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313638#comment-15313638 ] ramkrishna.s.vasudevan commented on HBASE-15879: ------------------------------------------------ bq.The model should not be such that Key only makes sense in case where row is contiguous with column family and qualifier, etc. Ok. So you mean make all Cell have a Key interface? I can come up with a patch where Key interface is implemented in every cell and not make Cell extend Key. bq.Streamable should be done with Codec? Yes. But there is some relation between this Streamable and Key. Streambale deals with both keys and values but Key is talking only about the key part. > Introduce Key interface > ----------------------- > > Key: HBASE-15879 > URL: https://issues.apache.org/jira/browse/HBASE-15879 > Project: HBase > Issue Type: Improvement > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Attachments: HBASE-15879.patch > > > Introduce an interface called Key and allow Cell implementations to implement this Key interface for cases like KeyValue, OffheapKeyValue and DBE cells (Except prefix tree) so that we can avoid copies when we deal with only Cells in case of block index creations (like ROOT, Bloom etc). Helps in reduction of garbage also. -- This message was sent by Atlassian JIRA (v6.3.4#6332)