Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 10 Jun 2016 16:59:21 +0000 (UTC)
From: "Stephen Yuan Jiang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12955424.1459547820000.55116.1465577961015@Atlassian.JIRA>
In-Reply-To: <JIRA.12955424.1459547820000@Atlassian.JIRA>
References: <JIRA.12955424.1459547820000@Atlassian.JIRA> <JIRA.12955424.1459547820146@arcas>
Subject: [jira] [Comment Edited] (HBASE-15584) Revisit handling of
 BackupState#CANCELLED
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 10 Jun 2016 16:59:27 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324802#comment-15324802 ] 

Stephen Yuan Jiang edited comment on HBASE-15584 at 6/10/16 4:58 PM:
---------------------------------------------------------------------

[~tedyu], current code in {{FullTableBackupProcedure#toStringClassDetails}} only contains backup root directory, you can add more information there (eg. such as backupId; or list of tables that backup is running).  

{code}
  @Override
  public void toStringClassDetails(StringBuilder sb) {
    sb.append(getClass().getSimpleName());
    sb.append(" (targetRootDir=");
    sb.append(targetRootDir);
    sb.append(")");
{code}

Also, I agree with [~mbertozzi] that we don't need backup ID for abort.  For in progress operation, proc Id should be sufficient.   The backup ID is more like meta data that stores in system table for future reference (eg. allows user to find history of backup; or the backup chain mixed with full and incremental).  


was (Author: syuanjiang):
[~tedyu], current code in {{FullTableBackupProcedure#toStringClassDetails}} only contains backup root directory, you can add more information there (eg. such as backupId; or list of tables that backup is running).  

{code}
  @Override
  public void toStringClassDetails(StringBuilder sb) {
    sb.append(getClass().getSimpleName());
    sb.append(" (targetRootDir=");
    sb.append(targetRootDir);
    sb.append(")");
{code}

> Revisit handling of BackupState#CANCELLED
> -----------------------------------------
>
>                 Key: HBASE-15584
>                 URL: https://issues.apache.org/jira/browse/HBASE-15584
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Priority: Minor
>
> During review of HBASE-15411, Enis made the following point:
> {code}
> nobody puts the backup in cancelled state. setCancelled() is not used. So if I abort a backup, who writes to the system table the new state? 
> Not sure whether this is a phase 1 patch issue or due to this patch. We can open a new jira and address it there if you do not want to do it in this patch. 
> Also maybe this should be named ABORTED rather than CANCELLED.
> {code}
> This issue is to decide whether this state should be kept (e.g. through notification from procedure V2 framework in response to abortion).
> If it is to be kept, the state should be renamed ABORTED.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)